[PATCH libinput 1/1] Fix debouncing algorithm

Peter Hutterer peter.hutterer at who-t.net
Mon Nov 20 02:54:44 UTC 2017


On Sun, Nov 19, 2017 at 08:45:16PM +0100, Vicente Bergas wrote:
> On Thursday, November 16, 2017 2:29:05 AM CET, Peter Hutterer wrote:
> > On Wed, Nov 15, 2017 at 09:31:07PM +0100, Vicente Bergas wrote:
> > > On Wed, Nov 15, 2017 at 1:38 AM, Peter Hutterer
> > > <peter.hutterer at who-t.net> wrote:
> > > > ... I'd appreciate it if you could give it a test
> > > > though.
> > > > 
> > > > Cheers,
> > > >    Peter
> > > 
> > > Hi Peter,
> > > just tested 4aa25b9de96321d946ed399b614d52deadf74403 (tip of your
> > > debouncing branch on github), it failed on the very first click:
> > > [  1910.895] (EE) event6  - ROCCAT ROCCAT Kone Pure: (EE) libinput
> > > bug: invalid debounce event DEBOUNCE_EVENT_RELEASE in state
> > > DEBOUNCE_STATE_IS_UP
> > > After this, it was like the left button was permanently pressed.
> > > OTOH, the patch I sent to the list has been debouncing my mouse for
> > > about a week with no issues, so far.
> > 
> > sorry, was just a bug. I had two states end up in IS_UP after a button
> > press. Switched them to IS_DOWN and all is good now, see commit
> > ba9e6012a52b.
> > 
> > Cheers,
> >    Peter
> 
> Hi Peter,
> ba9e6012a52b provided good results after two days testing.
> Definetly better than v1.9.1.

thanks, much appreciated! I've pushed this as 0e0dfe9bdfa now, with the fix
squashed in and the svg updated accordingly.

Cheers,
   Peter


More information about the wayland-devel mailing list