[PATCH wayland] cursor: add forward declaration for struct wl_buffer

Yong Bakos junk at humanoriented.com
Thu Oct 12 17:19:09 UTC 2017


Hi Emil,

> On Oct 12, 2017, at 5:39 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> 
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> This makes the header self-contained, since the struct is considered
> opaque from waylad-cursor POV.
> 
> As we're here move the wl_shm fwd. declaration alongside the others.
> Making it easier to read and track.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

This is the only other lingering type dependency in wayland-cursor.c coming
from wayland-client.h et al. So, similar to the wl_shm forward
declaration, this new declaration indeed makes the header self-contained.

Reviewed-by: Yong Bakos <ybakos at humanoriented.com>

Cheers,
yong


> ---
> cursor/wayland-cursor.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/cursor/wayland-cursor.h b/cursor/wayland-cursor.h
> index 09a13a7..40d3fc5 100644
> --- a/cursor/wayland-cursor.h
> +++ b/cursor/wayland-cursor.h
> @@ -33,6 +33,8 @@ extern "C" {
> #endif
> 
> struct wl_cursor_theme;
> +struct wl_buffer;
> +struct wl_shm;
> 
> struct wl_cursor_image {
> 	uint32_t width;		/* actual width */
> @@ -48,8 +50,6 @@ struct wl_cursor {
> 	char *name;
> };
> 
> -struct wl_shm;
> -
> struct wl_cursor_theme *
> wl_cursor_theme_load(const char *name, int size, struct wl_shm *shm);
> 
> -- 
> 2.14.1
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list