[PATCH wayland] cursor: add forward declaration for struct wl_buffer

Emil Velikov emil.l.velikov at gmail.com
Fri Oct 20 16:43:05 UTC 2017

On 12 October 2017 at 18:19, Yong Bakos <junk at humanoriented.com> wrote:
> Hi Emil,
>> On Oct 12, 2017, at 5:39 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>> This makes the header self-contained, since the struct is considered
>> opaque from waylad-cursor POV.
>> As we're here move the wl_shm fwd. declaration alongside the others.
>> Making it easier to read and track.
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> This is the only other lingering type dependency in wayland-cursor.c coming
> from wayland-client.h et al. So, similar to the wl_shm forward
> declaration, this new declaration indeed makes the header self-contained.
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
Thanks Yong.

FTR I've noticed this in light of a Mesa bug report [1].
In a tl;dr; deprecation warnings where present due to the notations in

Guess one should(?) use the core/protocol headers instead, if they're
feeling uncomfortable with -DWL_HIDE_DEPRECATED?
There is no documentation on the use of one vs the other set of headers though.

Anyone versed in the topic care to write something up - Giulio care to
do the honours ;-)


[1] https://bugs.freedesktop.org/show_bug.cgi?id=103225

More information about the wayland-devel mailing list