[PATCH weston 00/14] Desktop Protocol Support for IVI-Shell

Tue Oct 24 14:08:19 UTC 2017

I'm not at all familiar with the internal implementation of ivi-shell, so I
can't give much meaningful review. But I am very much in favor of this
patch series. Without wl_shell and xdg_shell support, I've never been able
to really give ivi-shell serious consideration on my products. The ability
to use generic client Wayland programs is very important.

-Matt

On Tue, Oct 17, 2017 at 5:51 AM, Ucan, Emre (ADITG/ESB) <
eucan at de.adit-jv.com> wrote:

> Hi,
>
> I already reviewed the patches before Michael sent:
> Reviewed-by: Emre Ucan <eucan at de.adit-jv.com>
>
> Best regards
>
> Emre Ucan
> Engineering Software Base (ADITG/ESB)
>
> Tel. +49 5121 49 6937
>
> > -----Original Message-----
> > From: wayland-devel [mailto:wayland-devel-
> > bounces at lists.freedesktop.org] On Behalf Of Michael Teyfel
> > Sent: Dienstag, 17. Oktober 2017 12:02
> > To: wayland-devel at lists.freedesktop.org
> > Subject: [PATCH weston 00/14] Desktop Protocol Support for IVI-Shell
> >
> > Hello all,
> >
> > since some time I’m working on ivi-shell to add xdg-protocol support by
> > means of libweston-desktop. Due to my changes both xdg-protocol
> > applications and ivi-shell / ivi-application-protocol applications are
> supported
> > within ivi-shell now. The known functionality is preserved and just
> extended
> > by a further protocol. The advantage is that client applications do not
> need to
> > be edited to generate an id and are also not limited to use the custom
> ivi-
> > application protocol anymore, since the ids are handled by an id agent
> inside
> > of weston now.
> >
> > As a preparation for the changes the goto labels in ivi-shell have been
> > reworked to avoid memory leaks. In ivi-layout I added an interface
> > (ivi_layout_surface_set_id) to set the surface-id of an
> ivi-layout-surface. It
> > can be done once after being created by an xdg-protocol application to
> assign
> > a numeric id by means of an id agent for example. Additionally I
> introduced a
> > new event to notify about a desktop surface being configured
> > (desktop_surface_configured). An id agent can register to this event and
> > react to this accordingly by assigning an id by means of
> > ivi_layout_surface_set_id. As a result I also changed the test client
> > applications in the Weston repository and removed the ivi-application
> > protocol support since that has only been used, if xdg protocol is not
> > supported. Finally hmi-controller has been edited to accept desktop
> > surfaces.
> >
> > There are some things that can be done in the future:  At first it would
> be
> > diligent, if hmi-controller would also use xdg protocol for the GUI
> itself. Then
> > also the surface_configure event could be removed from hmi-controller.
> > Secondly the weston unit tests should also test the interface changes for
> > surface_set_id and also should stop using the ivi-application protocol.
> >
> > Thanks for reading and questions are very welcome.
> >
> >
> > Best regards
> >
> > Michael Teyfel
> > Advanced Driver Information Technology GmbH
> > Engineering Software Base (ADITG/ESB)
> > Robert-Bosch-Str. 200
> > 31139 Hildesheim
> > Germany
> > Tel. +49 5121 49 6932
> > Fax +49 5121 49 6999
> > mteyfel at de.adit-jv.com
> > ADIT is a joint venture company of Robert Bosch GmbH/Robert Bosch Car
> > Multimedia GmbH and DENSO Corporation
> > Sitz: Hildesheim, Registergericht: Amtsgericht Hildesheim HRB 3438
> > Geschäftsführung: Wilhelm Grabow, Ken Yaguchi
> >
> >
> > Michael Teyfel (14):
> >   ivi-shell: rework goto labels to avoid memory leaks
> >   ivi-shell: removed assert
> >   ivi-shell: introduction of IVI_INVALID_ID
> >   layout-interface: added interface to change surface id
> >   ivi-layout: introduced configure_desktop_changed
> >   ivi-layout: introduced surface create and configure
> >   ivi-shell: linked libweston-desktop and added structs
> >   ivi-shell: added libweston-desktop-api implementation
> >   ivi-shell: remove surface_destroy_listener
> >   ivi-shell: create weston_desktop in wet_shell_init
> >   hmi-controller: register for desktop_surface_configured
> >   simple-egl: remove ivi-application support
> >   simple-shm: remove ivi-application support
> >   window client: remove ivi-application support
> >
> >  Makefile.am                    |  11 +--
> >  clients/simple-egl.c           |  86 +++-------------
> >  clients/simple-shm.c           |  40 --------
> >  clients/window.c               |  44 +--------
> >  ivi-shell/hmi-controller.c     |  70 +++++++------
> >  ivi-shell/ivi-layout-export.h  |  18 ++++
> >  ivi-shell/ivi-layout-private.h |   3 +
> >  ivi-shell/ivi-layout-shell.h   |   8 ++
> >  ivi-shell/ivi-layout.c         | 142 ++++++++++++++++++++++-----
> >  ivi-shell/ivi-shell.c          | 218
> > ++++++++++++++++++++++++++++++++++++++---
> >  ivi-shell/ivi-shell.h          |   2 +
> >  11 files changed, 407 insertions(+), 235 deletions(-)
> >
> > --
> > 2.7.4
> >
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/wayland-devel
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20171024/3406bad8/attachment-0001.html>