[PATCH weston v6 65/73] compositor-drm: no need to clear inherited_mode

Daniel Stone daniel at fooishbar.org
Thu Apr 12 13:19:33 UTC 2018


Hi Pekka,

On 16 February 2018 at 15:57, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> The head was just zalloc()'d, there is no need to memset it to zero.
>
> If a function fails, it is preferable it leaves the output arguments
> untouched.

Everything to this point is:
Reviewed-by: Daniel Stone <daniels at collabora.com>

and I'm happy for you to merge. Given I'm away today and tomorrow, I
won't be able to properly test multi-head and hotplugging until next
week, so if you want to go ahead and land it, I'll rebase the
remainder of the atomic series on top of that, fix the inevitable
bugs, and send it out.

I'm really happy with how this series has unfolded: there were a
couple of small places where things seemed mis-sequenced, but on the
whole it was very easy to read through and find a coherent story. Much
less scary than I feared. Thanks!

Cheers,
Daniel


More information about the wayland-devel mailing list