[PATCH weston v6 69/73] compositor-drm: head attach requires a modeset

[Daniel Stone]

Hi,

On 18 April 2018 at 13:37, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Wed, 18 Apr 2018 12:09:45 +0300 Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> Sure, I'll see about adding that.
>
> looks like I would get into a bit of pickle in
> drm_pending_state_apply_atomic() if struct drm_output has heads_dirty
> flag.
>
> Currently the loop over heads is inside state_invalid==true branch, and
> I would need to take it out of there if I no longer set state_invalid.
> But when I go through the heads, I would not know which output they
> were removed from, so I cannot check the output->heads_dirty flag.
> Seems like I would need to add pending_removal flag to drm_head or add
> a list of removed connectors to the drm_output.

Oh, right. I can't think of a good way to get around that as it
stands. I think the best thing for now would be to leave the XXX in
there, and we can revisit it when the dust has settled, but for now
just setting state_invalid is fine.

Thanks for following up!

Cheers,
Daniel