[PATCH weston] desktop-shell: fix shell_output_destroy_move_layer unused variable

Daniel Stone daniel at fooishbar.org
Tue Feb 13 15:57:33 UTC 2018


Hi Pekka,

On 13 February 2018 at 14:21, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> /home/pq/git/weston/desktop-shell/shell.c: In function ‘shell_output_destroy_move_layer’:
> /home/pq/git/weston/desktop-shell/shell.c:4718:24: warning: unused variable ‘output’ [-Wunused-variable]
>   struct weston_output *output = data;
>
> Since the data pointer is not used for anything, decided to also set it
> to NULL in the caller. This caused another variable to become unused.

I just noticed that earlier whilst having fun with distcheck. Thanks for that.

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the wayland-devel mailing list