[PATCH weston] desktop-shell: fix shell_output_destroy_move_layer unused variable

Pekka Paalanen ppaalanen at gmail.com
Wed Feb 14 08:07:49 UTC 2018


On Tue, 13 Feb 2018 15:57:33 +0000
Daniel Stone <daniel at fooishbar.org> wrote:

> Hi Pekka,
> 
> On 13 February 2018 at 14:21, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > /home/pq/git/weston/desktop-shell/shell.c: In function ‘shell_output_destroy_move_layer’:
> > /home/pq/git/weston/desktop-shell/shell.c:4718:24: warning: unused variable ‘output’ [-Wunused-variable]
> >   struct weston_output *output = data;
> >
> > Since the data pointer is not used for anything, decided to also set it
> > to NULL in the caller. This caused another variable to become unused.  
> 
> I just noticed that earlier whilst having fun with distcheck. Thanks for that.
> 
> Reviewed-by: Daniel Stone <daniels at collabora.com>

Pushed:
   5b0aa55d..9350bfd9  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180214/2144b5b1/attachment.sig>


More information about the wayland-devel mailing list