[PATCH wayland] client: Don't inappropriatly close fds for zombie objects

Daniel Stone daniel at fooishbar.org
Wed Mar 7 15:16:33 UTC 2018


On 6 March 2018 at 23:38, Derek Foreman <derekf at osg.samsung.com> wrote:
> commit 239ba39331420f953de35c337ae57db35573f9cb which was intended
> to stop leaking fds in events for zombie objects didn't notice that
> passing 0 to wl_connection_close_fds_in() would still close fds.
>
> Test the fd count before calling.

Ouch. I misread the 'size == 0' check at the top of close_fds_in() for
'max == 0', and thought that was OK. Oh well.

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the wayland-devel mailing list