[PATCH wayland] client: Don't inappropriatly close fds for zombie objects

Derek Foreman derekf at osg.samsung.com
Wed Mar 7 15:23:54 UTC 2018


On 2018-03-07 09:16 AM, Daniel Stone wrote:
> On 6 March 2018 at 23:38, Derek Foreman <derekf at osg.samsung.com> wrote:
>> commit 239ba39331420f953de35c337ae57db35573f9cb which was intended
>> to stop leaking fds in events for zombie objects didn't notice that
>> passing 0 to wl_connection_close_fds_in() would still close fds.
>>
>> Test the fd count before calling.
> 
> Ouch. I misread the 'size == 0' check at the top of close_fds_in() for
> 'max == 0', and thought that was OK. Oh well.

Sure, I'm going to claim that as my error as well.

> Reviewed-by: Daniel Stone <daniels at collabora.com>

And pushed.

Thanks,
Derek

> Cheers,
> Daniel
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
> 



More information about the wayland-devel mailing list