unique id for wayland objects

Michel Dänzer michel at daenzer.net
Wed May 30 16:12:44 UTC 2018


On 2018-05-30 02:48 PM, Pekka Paalanen wrote:
> On Wed, 30 May 2018 18:33:40 +0800
> zou lan <nancy.lan.zou at gmail.com> wrote:
> 
>> Hi pekka
>>
>> I'm not familiar with kernel. I know part of drm driver is implement by
>> ourself. I check the vblank callback function, it sends pageflip event
>> first if there is a frame complete, update vblank timestamp later.
>>
>> I don't know why the owner write code like this. but if I swap the code
>> order, the fps  decrease a lot.
> 
> Hi Nancy,
> 
> I do not know your hardware, so I cannot say why fps decreases, but the
> order of sending event first and updating the timestamp later does
> sound wrong to me.

Yes, drm_handle_vblank must be called before drm_crtc_send_vblank_event,
otherwise it's not surprising that the timestamp in the event is wrong. :)


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 224 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180530/346fe60f/attachment.sig>


More information about the wayland-devel mailing list