tests: fix main symbol duplication

Pekka Paalanen ppaalanen at gmail.com
Fri Feb 8 10:51:23 UTC 2019

On Fri, 8 Feb 2019 12:23:06 +0200
Leonid Bobrov <mazocomp at disroot.org> wrote:

> On Fri, Feb 08, 2019 at 12:09:09PM +0200, Pekka Paalanen wrote:
> > Hi Leonid,
> >   
> Hi Pekka,
> > your approach to fix these issues looks good to me, and the commit
> > message explains everything I could ask for, except for maybe
> > mentioning that the linker is one from OpenBSD, was it?
> > 
> > Unfortunately it seems the patch is somehow malformed:
> > 
> > git am -3 /home/pq/.claws-mail/imapcache/imap.gmail.com/ppaalanen at gmail.com/lists/wayland-devel/39311
> > -----------------------------------------------------------------------
> > Applying: tests: fix main symbol duplication
> > error: git diff header lacks filename information when removing 1 leading pathname component (line 9)
> > error: could not build fake ancestor
> > Patch failed at 0001 tests: fix main symbol duplication
> > 
> > It does not look like it came from git-format-patch.
> >   
> Weird, because I ran $ git format-patch HEAD~1

Weird indeed. Did you manually edit the patch, or copy & paste it?

The diff line file names are missing the typical a/ and b/ like this:

diff --git a/libweston-desktop/internal.h b/libweston-desktop/internal.h
index 2f2af98c..ce853ba9 100644
--- a/libweston-desktop/internal.h
+++ b/libweston-desktop/internal.h

> > Could you retry, please?
> > 
> > I guess that you might be sending more patches, therefore it would be
> > nice to get the workflow in order so I don't have to manually redo
> > every patch.
> >   
> Yes, I am preparing more patches, trying to divide src/event-loop.c
> into src/event-loop-epoll.c and srs/event-loop-kqueue.c
> > Would you consider adding a Signed-off-by as well to show that you
> > agree to https://developercertificate.org/ too?
> >   
> I don't know how to do that, besides I have no intention to license code
> I submit, so you are completely free to use it.

The way you do that is you put

Signed-off-by: Your Real Name <email at address>

at the end of each commit message. You can check almost any existing
Wayland commit for an example.

If you do not license your code under the very license the project is
using, then we cannot take your contributions at all. No license means
no-one can do anything with it, particularly redistribute it. I once saw
someone say: the copyright law makes no difference between your patch
and the latest Disney movie.

No license: no rights.

"Feel free to use it" is not a license. We really do need a valid
license for all contributions. The way that happens is that people
check the project license (in this case it is duplicated in the top of
almost every source file, and in the COPYING file at the root
directory) and agree to that. Putting your S-o-b in the commit message
is an explicit indicator that you agree, but also the fact that you
sent a patch at all can also be taken as an agreement.


> > S-o-b is mentioned in
> > https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md#sending-patches .
> > 
> > 
> > Thanks,
> > pq
> >   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20190208/6be22127/attachment-0001.sig>

More information about the wayland-devel mailing list