[PATCH weston v3 00/17] Tablet device support for weston

[Pekka Paalanen]

On Wed, 20 Dec 2017 09:02:26 -0800
Jason Gerecke <killertofu at gmail.com> wrote:

> On Tue, Dec 19, 2017 at 12:33 AM, Maniraj Devadoss
> <Maniraj.Devadoss at in.bosch.com> wrote:
> > Hi Jason,
> >
> > I found the root cause for the backtrace you shared
> > https://lists.freedesktop.org/archives/wayland-devel/2017-November/035964.html
> >
> > The issue is that the tablet tool's surface and view is not
> > set as mapped in tablet_tool_cursor_surface_configure API,
> > so the same view can be added more than once to the cursor
> > layer list when the set_cursor is called by the client. This will
> > lead to corruption of cursor layer list.
> >
> > The issue is resolved with this patch series,
> > Can you please test the same and let us know the result.
> >
> > Best Regards,
> > Maniraj D.
> >  
> 
> Awesome, thanks! I've given the patch a quick test and the crash does
> seem to be resolved. I'm now able to interact with shell components
> (e.g. dragging windows) and the weston-tablet demo also appears to
> work. I do notice that there are some issues with swapping back and
> forth between the stylus and eraser within weston-tablet, however
> (sometimes it erases with the tip, or draws with the eraser). I've
> also tried running the "mypaint", which is a GTK3 drawing application.
> Its able to use use the Wayland tablet protocol when run under Mutter,
> but it doesn't seem to get any tablet events when running inside
> Weston.
> 
> I'll take another look at the beginning of January when I'm back from
> vacation. Hopefully I can be a bit more helpful with the debugging now
> that things aren't crashing. :)
> 
> Jason
> ---
> Now instead of four in the eights place /
> you’ve got three, ‘Cause you added one  /
> (That is to say, eight) to the two,     /
> But you can’t take seven from three,    /
> So you look at the sixty-fours....
> 
> > Bastian Farkas (3):
> >   tablet: Fixed compilation errors resulting from tablet patches.
> >   tablet: Fixing compilation issues in weston desktop-shell related to
> >     tablet     support patches.
> >   tablet: reordered changes in weston_seat struct to not break ABI
> >     compatibility
> >
> > Lyude Paul (13):
> >   tablet: Add initial tablet support to weston
> >   tablet: add handling of tablet focus
> >   tablet: add weston grab interfaces for tablet tools
> >   tablet: hook up libinput tablet events
> >   tablet: handle tablet cursors in the compositor
> >   clients: add support for handling tablets
> >   client: Add tablet cursor support into libtoytoolkit
> >   client: Add support for tablet cursor motion to window frames in
> >     libtoytoolkit
> >   tablet: Add support for moving windows around using the stylus
> >   tablet: Add tablet support to the top panel of the desktop shell
> >   tablet: Add binding to activate surfaces using the tablet tool
> >   tablet: Add demo application for tablets
> >   tablet: Remove tablet-specific tools on disconnect
> >
> > Maniraj Devadoss (1):
> >   tablet: unmap the surface only if the sprite is not NULL
> >
> >  .gitignore                  |   1 +
> >  Makefile.am                 |  20 +-
> >  clients/desktop-shell.c     |  56 +++
> >  clients/tablet.c            | 254 ++++++++++++
> >  clients/window.c            | 686 +++++++++++++++++++++++++++++++
> >  clients/window.h            |  93 +++++
> >  configure.ac                |   2 +-
> >  desktop-shell/shell.c       | 289 +++++++++++++
> >  libweston/bindings.c        |  39 +-
> >  libweston/compositor.c      |   8 +
> >  libweston/compositor.h      | 204 ++++++++++
> >  libweston/input.c           | 965 ++++++++++++++++++++++++++++++++++++++++++++
> >  libweston/libinput-device.c | 340 ++++++++++++++++
> >  libweston/libinput-device.h |   4 +-
> >  shared/cairo-util.h         |   4 +
> >  shared/frame.c              |  38 ++
> >  16 files changed, 2996 insertions(+), 7 deletions(-)
> >  create mode 100644 clients/tablet.c

Hello,

I noticed this series is still pending. Tablet support in Weston would
be cool, but it does have the practical problem of not having many
people who can test it, or even review I guess. I welcome re-submitting
a rebased version of this in Gitlab to see if there is new interest.

https://gitlab.freedesktop.org/wayland/weston/blob/master/CONTRIBUTING.md

In the mean time I'll mark this series as "changes requested" because
the very least it needs rebasing. Looking at the list of touched files
though maybe it's not very hard to do.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20200131/a7e4a5e2/attachment.sig>