[PATCH weston 2/2] simple-dmabuf-drm: use GBM generic calls

[Pekka Paalanen]

On Fri, 20 Jul 2018 21:21:59 +0200
Guido Günther <agx at sigxcpu.org> wrote:

> Hi,
> On Thu, Jul 19, 2018 at 04:45:02PM +0200, Emilio Pozuelo Monfort wrote:
> > No need to write libdrm driver specific code for each supported
> > driver, we can just let GBM call the right one for us now.
> > 
> > Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo at collabora.co.uk>
> > ---
> > Some improvements from Daniel (thanks!). I also added missing error messages,
> > formatting fixes and a logic error in your improvements that caused NV12 to
> > abort if create_bo was working fine.
> > 
> > No changes to XRGB, so that's likely to still fail for you. I suspect
> > a bug in mesa's i965 code, I can look at that separately.
> > 
> > Cheers,
> > Emilio
> > 
> >  clients/simple-dmabuf-drm.c | 444 ++++++++++--------------------------
> >  configure.ac                |   2 +-
> >  2 files changed, 122 insertions(+), 324 deletions(-)

Hi,

thanks for the patches, I noticed these two weren't in yet. In the
mean time, simple-dmabuf-drm has been deleted and replaced with
simple-dmabuf-v4l (with help from vivid kernel module) and
simple-dmabuf-egl. Please, open issues in Gitlab if those two cannot
test some cases you might need.

The driver-specific code in simple-dmabuf-drm became a pain for both
users and developers, so it is unlikely to come back.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20200131/262cf3d0/attachment.sig>