Fwd: Empty IN_FORMATS in sun4i-drm

[Emmanuel Gil Peyrot]

Hi, this message I sent earlier about the kernel is also relevant to
this mailing list, I forgot to CC it:

----- Forwarded message from Emmanuel Gil Peyrot <linkmauve at linkmauve.fr> -----

Date: Tue, 14 Dec 2021 13:02:48 +0100
From: Emmanuel Gil Peyrot <linkmauve at linkmauve.fr>
To: Maxime Ripard <mripard at kernel.org>, Chen-Yu Tsai <wens at csie.org>, dri-devel at lists.freedesktop.org, linux-sunxi at lists.linux.dev
Subject: Empty IN_FORMATS in sun4i-drm

Hi,

After updating Weston from 9f8561e9 to 07326040 (latest master), it
fails to run on my PinePhone saying “format 0x34325258 not supported by
output DSI-1” and then exiting.

This format is XR24, which would be extremely surprising not to be
present, and drm_info[1] says it is present.  Looking into Weston’s
code, I found that drm_plane_populate_formats()’s docstring says it uses
“either the IN_FORMATS blob property (if available), or the plane's
format list if not.”  Looking back at drm_info, I saw said IN_FORMATS
blob being empty of formats (while the format list is fully populated):
"IN_FORMATS" (immutable): blob = 32
└───DRM_FORMAT_MOD_LINEAR (0x0)

This makes me think the kernel should populate IN_FORMATS with at least
the same formats as the format list when supported, or stop advertising
this property altogether.

Other compositors (such as phoc) still run file, probably because they
use the format list exclusively, without consideration for modifiers.

Besides fixing this driver, would it make sense to also make Weston
ignore an empty IN_FORMATS and fall back to the format list?

Thanks,

[1] https://github.com/ascent12/drm_info

-- 
Emmanuel Gil Peyrot

----- End forwarded message -----

-- 
Emmanuel Gil Peyrot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20211214/e03a9159/attachment.sig>