Buffer Damage

[Simon Ser]

On Monday, January 4th, 2021 at 1:00 PM, Vlad Zahorodnii <vlad.zahorodnii at kde.org> wrote:

> On 1/4/21 1:33 PM, Simon Ser wrote:
>
> > On Monday, January 4th, 2021 at 12:23 PM, Vlad Zahorodnii vlad.zahorodnii at kde.org wrote:
> >
> > Do you have real-world examples where the buffer damage would improve
> > performance?
>
> Buffer damage is needed once the compositor no longer attaches shared
> memory client buffers to a single texture. Normally, buffer damage would
> include a region that got repaired + surface damage in buffer-local
> coordinates.
>
> > Note, many clients now use some kind of hardware acceleration, which
> > wouldn't benefit from this optimization.
>
> There are still too many popular applications that use QtWidgets, for
> example, qBittorrent, Konsole, Telegram (Desktop), etc. They all provide
> shared memory buffers.

I don't think these would benefit from the optimization you're
suggesting. They don't cycle between pre-rendered buffers, for
instance.

I don't think it's worth implementing an optimization if it only
improves performance in synthetic edge cases that never happen in
real-world scenarios.