Status of icc profile integration for output devices?

Sat Jan 20 14:51:06 UTC 2024

Hello Pekka,

Thank you very much for your answer. Correcting the key from "icc-profile" to "icc_profile" did the trick.

Best,
Markus 

> -----Original Message-----
> > Hi there,
> >
> > Let me start with an apology posting this here on the development
> > mailing list rather than somewhere more user related. Unfortunately, I
> > couldn't find a forum/community for Weston/Wayland, so if there is a
> > better place please let me know.
> 
> Hi Markus,
> 
> no worries, this is a good place for Weston, the other is filing a issue in Gitlab
> for Weston.
> 
> > I was trying for a couple of days now to apply an output icc-profile
> > to Weston (13.0.90), but it seems to have no impact. So I am not sure
> > if there is an error in my weston.ini file, if the profiles are not
> > applied in the way I would expect them to or if this functionality is
> > not fully implemented. Regarding the latter I went through the release
> > history and saw in some discussions about color management and HDR
> > that this feature should be implemented about 2 years ago, but maybe I
> > misunderstood. I would be grateful for any clarification.
> 
> When properly configured, Weston will do *something* with an output ICC
> profile, but whether that something is in any way correct has not really been
> thought about yet. If you set up an ICC display profile that does something
> wild, you should see it.
> 
> > Here my setup:
> > The idea was to have a green background in the shell, and apply an icc
> > profile that swaps green and red colors (SwappedRedAndGreen.icc was
> > available in my Ubuntu installation) , so I would expect to see a red
> > background in the compositor when the icc profile is applied.
> > However, the background does not change.
> >
> 
> > My weston.ini:
> >
> > [core]
> > color-management=true
> > [shell]
> > background-color=0xff00ff00
> > [output]
> > name=WL1
> > mode=300x400
> > icc-profile=/usr/share/color/icc/colord/SwappedRedAndGreen.icc
> 
> The key is icc_profile, not icc-profile. Yeah, we're terrible with - vs. _
> consistency.
> 
> >
> > The corresponding startup log:
> > Date: 2023-12-20 EST
> > [21:04:01.696] weston 13.0.90
> >                https://wayland.freedesktop.org
> >                Bug reports to:
> https://gitlab.freedesktop.org/wayland/weston/issues/
> >                Build: 13.0.0-25-gb72785e1 [21:04:01.696] Command line:
> > weston [21:04:01.696] OS: Linux, 6.2.0-39-generic, #40~22.04.1-Ubuntu
> > SMP PREEMPT_DYNAMIC Thu Nov 16 10:53:04 UTC 2, x86_64 [21:04:01.696]
> > Flight recorder: enabled [21:04:01.696] Using config file
> > '/home/mgramer/.config/weston.ini'
> > [21:04:01.696] Output repaint window is 7 ms maximum.
> > [21:04:01.696] Loading module '/home/mgramer/install/lib/x86_64-linux-
> gnu/libweston-13/color-lcms.so'
> > [21:04:01.698] Loading module '/home/mgramer/install/lib/x86_64-linux-
> gnu/libweston-13/wayland-backend.so'
> > [21:04:01.734] Loading module '/home/mgramer/install/lib/x86_64-linux-
> gnu/libweston-13/gl-renderer.so'
> > warning: queue 0x5595f599cdf0 destroyed while proxies still attached:
> >   wl_display#1 still attached
> > [21:04:01.799] warning: failed to query rendering device from EGL
> > [21:04:01.799] EGL version: 1.5 [21:04:01.799] EGL vendor: Mesa
> > Project [21:04:01.799] EGL client APIs: OpenGL OpenGL_ES
> > [21:04:01.799] warning: Disabling render GPU timeline and explicit
> > synchronization due to missing EGL_ANDROID_native_fence_sync
> extension [21:04:01.799] EGL features:
> >                EGL Wayland extension: no
> >                context priority: no
> >                buffer age: no
> >                partial update: no
> >                swap buffers with damage: no
> >                configless context: yes
> >                surfaceless context: yes
> >                dmabuf support: no
> > [21:04:01.813] GL version: OpenGL ES 3.2 Mesa 23.0.4-0ubuntu1~22.04.1
> > [21:04:01.813] GLSL version: OpenGL ES GLSL ES 3.20 [21:04:01.813] GL
> > vendor: Mesa [21:04:01.813] GL renderer: llvmpipe (LLVM 15.0.7, 128
> > bits) [21:04:01.837] GL ES 3.2 - renderer features:
> >                read-back format: ARGB8888
> >                glReadPixels supports y-flip: yes
> >                wl_shm 10 bpc formats: yes
> >                wl_shm 16 bpc formats: yes
> >                wl_shm half-float formats: yes
> >                internal R and RG formats: yes
> >                OES_EGL_image_external: yes [21:04:01.837] Using GL
> > renderer [21:04:01.837] Registered plugin API
> > 'weston_windowed_output_api_v2' of size 16 [21:04:01.839] LittleCMS
> > 2120 initialized.
> > [21:04:01.839] Color manager: work-in-progress [21:04:01.839] Output
> > 'WL1' attempts EOTF mode: SDR [21:04:01.843] Output 'WL1' using color
> > profile: ICCv4.3 sRGB stock 02c51d4714d85e96bb1e99ed25e8edd2
> 
> This here says the weston.ini settings did not work, the output is still using a
> stock sRGB profile. The message changes when it loads your profile.
> 
> 
> Thanks,
> pq
> 
> > [21:04:01.843] Creating 300x400 wayland output at (0, 0)
> > [21:04:01.868] wayland-backend: Using xdg_wm_base [21:04:01.868]
> > Chosen EGL config details: id:  21 rgba: 8 8 8 8 buf: 32 dep:  0 stcl:
> > 0 int: 0-1 type: win vis_id: 0 [21:04:01.870] Output WL1 uses 16F shadow.
> > [21:04:01.895] Output 'WL1' enabled with head(s) WL1 [21:04:01.895]
> > Compositor capabilities:
> >                arbitrary surface rotation: yes
> >                screen capture uses y-flip: yes
> >                cursor planes: no
> >                arbitrary resolutions: no
> >                view mask clipping: yes
> >                explicit sync: no
> >                color operations: yes
> >                presentation clock: CLOCK_MONOTONIC_RAW, id 4
> >                presentation clock resolution: 0.000000001 s
> > [21:04:01.896] Loading module '/home/mgramer/install/lib/x86_64-linux-
> gnu/weston/desktop-shell.so'
> > [21:04:01.898] launching '/home/mgramer/install/libexec/weston-
> keyboard'
> > [21:04:01.901] launching '/home/mgramer/install/libexec/weston-desktop-
> shell'
> > [21:04:02.193] Chosen EGL config details: id:  21 rgba: 8 8 8 8 buf:
> > 32 dep:  0 stcl: 0 int: 0-1 type: win vis_id: 0 [21:04:02.194] Output WL1 uses
> 16F shadow.
> > warning: queue 0x5595f59a9bf0 destroyed while proxies still attached:
> >   wl_display#1 still attached
> >
> >
> > Thanks in advance for any advice and clarifications.
> >
> > Markus
> >