[Xcb] Status of XCB and howto begin

[Vincent Torri]

Ok, let's go for the pragma. So here is wat I plan :

1) put in ac_include.m4 a macro that check if gcc can compile a program
with the --fvisibility=hidden passed as flag. If so, the pragma will be
supported.

2) add that macro into configure.ac and pass a -D flag to gcc if the
visibility feature is supported

3) embed the pragma in #ifdef #endif

is it good enough ? If so, i'll post the changes.

On Thu, 9 Feb 2006, Jamey Sharp wrote:

> On Wed, Feb 08, 2006 at 09:34:10PM +0100, Vincent Torri wrote:
> > Here are 2 patch for xcbint.h
> >
> > the one with the __attribute__, the other with the pragma
>
> Awesome! Thanks, Vincent!
>
> Could you regenerate these as patches (diffs) instead of whole files?
> They're easier to review that way.
>

i've not sent the diff ?? i've made them. Maybe i've not sent the good
files :)

> If I promise never to take the address of any of the functions in
> xcbint.h, you can get even better improvements, right? (That's internal
> visibility I think?) Well, I promise. Would you make the appropriate
> change?

in the .so file, all the _xcb_* functions are not exported. The file size
of libXCB.so is a bit lesser than without that stuff. Nevertheless,
stripping the library with strip reduced the size even more. So that
visibility feature is not optimal, i think.

Vincent