[Xcb] low-level API changes

[Jamey Sharp]

On Tue, Mar 07, 2006 at 09:27:04AM +0100, Vincent Torri wrote:
> i've already sent the patch for the visibility feature, but you don't
> commit it, and you change xcbint.h (which is modified in my patch)...

Gah. Yes, I know. I'm sorry. I'm committing this right now.

Though your patch still applied just fine to xcbint.h. patch is smart
enough to handle me inserting a line in the middle of the file when you
touched only the beginning and end.

In the future, though, could you keep the following kinds of changes out
of your patches? I'm happy to have them submitted separately, but
patches and commits need to be minimal so we can look back at them later
and figure out what happened.

Also I won't take -W if it's as overzealous as it seems: you can just
set it in your CFLAGS, which aren't touched by this configure script.

--Jamey

On Sat, Mar 04, 2006 at 09:55:14AM +0100, Vincent Torri wrote:
> --- xcbint.h	2006-03-04 10:01:35.681578751 +0100
> +++ xcbint.h.old	2006-03-04 09:43:01.860275538 +0100
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (C) 2001-2004 Bart Massey and Jamey Sharp.
> + * Copyright (C) 2001-2006 Bart Massey and Jamey Sharp.
>   * All Rights Reserved.
>   *
>   * Permission is hereby granted, free of charge, to any person obtaining a
> @@ -8,17 +8,17 @@
>   * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>   * and/or sell copies of the Software, and to permit persons to whom the
>   * Software is furnished to do so, subject to the following conditions:
> - * 
> + *
>   * The above copyright notice and this permission notice shall be included in
>   * all copies or substantial portions of the Software.
> - * 
> + *
>   * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>   * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
>   * AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
>   * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
>   * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> - * 
> + *
>   * Except as contained in this notice, the names of the authors or their
>   * institutions shall not be used in advertising or otherwise to promote the
>   * sale, use or other dealings in this Software without prior written

> --- configure.ac	2006-03-04 10:00:42.353458376 +0100
> +++ configure.ac.doc	2006-03-04 08:43:43.839711835 +0100
> @@ -95,10 +95,12 @@
>  AC_CACHE_CHECK([what debugging options to apply], [CDEBUGFLAGS], [CDEBUGFLAGS="-g"])
>  AC_SUBST(CDEBUGFLAGS)
>  
> -CWARNFLAGS="-Wall -pedantic -Wpointer-arith \
> +CWARNFLAGS="-Wall -W -pedantic -Wpointer-arith \
>  	-Wstrict-prototypes -Wmissing-declarations -Wnested-externs"
>  AC_SUBST(CWARNFLAGS)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20060307/fe5e439d/attachment.pgp