[Xcb] xcb with BSD make and on DragonFly

Barton C Massey bart at cs.pdx.edu
Tue Mar 7 23:37:14 PST 2006


In message <20060308071149.GF5981 at id.minilop.net> you wrote:
> On Tue, Mar 07, 2006 at 09:53:21PM -0800, Jeremy C. Reed wrote:
> > 1) Will released versions of xcb source require
> > [xsltproc]? (I haven't looked yet, but didn't see
> > discussion on wiki or INSTALL.)
> 
> Is xsltproc specifically a problem, or are you concerned about the use
> of XSLT generally?

At minimum, we should ship pre-xsltproc-ed versions of all
the XCB headers.  I personally have no problem with
requiring XCB developers to have specific build tools, but I
think we shouldn't require anything too magic of folks who
just want to build and install it.

The problem is that SCMSs generally don't like to have stuff
in them that is "stored but not tracked".  Does GIT have
something like this?

> > 3) Building fails with:
> >
> > In file included from /usr/include/sys/select.h:41,
> >                  from xcb_util.c:29:
> > /usr/include/sys/event.h:54: error: syntax error before "uintptr_t"
> > /usr/include/sys/event.h:56: error: syntax error before "u_short"
> > In file included from xcb_util.c:29:
> > /usr/include/sys/select.h:49: error: syntax error before "pid_t"
> > In file included from xcb_util.c:30:
> > /usr/include/sys/socket.h:206: error: `int64_t' undeclared here (not in a function)
> > ...
> 
> I have to say this looks like a buggy select.h to me:
> header files should #include whatever they need, and this
> one apparently doesn't.

Nah.  Your philosophy was not shared by many early UNIX
folks.  I have always been an "header files shouldn't
include other header files" type myself, but the world has
decided to disagree with me on this one, so I just go
along. :-) You will note, though, that your way leads to the
scary valley of "wrapping header files in an ifdef to ensure
that they can harmlessly be included twice".

> But I think your fix is harmless, so I'll commit it.
[...]
> This really bugs me, for the same reason as above. I'll
> commit your fix, but I'm not happy about it.

The important part is that you fixed it.  Don't worry!  Be
happy. :-)


Thanks hugely, Jeremy, for the report!

    Bart


More information about the Xcb mailing list