[Xcb] Bug 6254: remove XCB's xproto/X11 dependency
Ian Osgood
iano at quirkster.com
Wed Mar 15 11:27:01 PST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Mar 15, 2006, at 10:54 AM, Jamey Sharp wrote:
> On Wed, Mar 15, 2006 at 10:33:07AM -0800, Ian Osgood wrote:
>> OK, I've removed X.h dependencies from xcb, xcb-util, and xcb-demo.
>> Would you like to review my changes before I push to origin?
>
> Naw, I'm sure you've done a fine job. :-)
>
> If there are small commits you can make separately, it's always
> nice to
> have them split up in the repository history -- especially now that
> there's git-bisect to binary-search for the revision that broke things
> when you're trying to track down a bug. But this change seems pretty
> harmless so one big commit would be OK too.
Done. Already in smaller commits, now that I'm getting the hang of git.
>> The final step would be to remove X.h from xcb.h, but this would
>> (trivially) break any project which currently uses XCB.
>
> Yeah... Well, probably we should make that change before release.
>
> --Jamey
There are still many X.h constants to move to xproto.h, but none of them
are currently being used in XCB itself. Time to write more demos?
Ian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
iD8DBQFEGGqJHDwFgzc3zyIRAiIUAJ4/vWStYCR680tlEMdUA6P66oUXNgCeKnqj
fj/y9Ic8jFgVRQXiAD71NYU=
=D+iU
-----END PGP SIGNATURE-----
More information about the Xcb
mailing list