[Xcb] Branch 'xspec' - xcb-proto

Josh Triplett josh at freedesktop.org
Fri Mar 17 11:07:44 PST 2006


Ian Osgood wrote:
> I've also been changing the names of constants as I move them from  X.h
> to xproto.xml.
> 
>  BadRequest   --> XCBRequest (should be XCBBadRequest or  XCBRequestError?)
>  ShiftMask    --> XCBModMaskShift
>  Mod1Mask     --> XCBModMask1
>  Button1Mask  --> XCBButtonMask1
>  InputOutput  --> XCBWindowClassInputOutput
>  WhenMapped   --> XCBBackingStoreWhenMapped
>  KeyPressMask --> XCBEventMaskKeyPress
>  IsViewable   --> XCBMapStateViewable
>  CWX          --> XCBConfigWindowX
>  LineSolid    --> XCBLineStyleSolid
>  CapButt      --> XCBCapStyleButt
>  JoinRound    --> XCBJoinStyleRound
>  FillTile     --> XCBFillStyleTile
>  WindingRule  --> XCBFillRuleWinding
>  XYBitmap     --> XCBImageFormatXYBitmap  (should be 
> XCBImageFormatBitmap?)
>  LSBFirst     --> XCBImageOrderLSBFirst
> 
> This is due mainly to the naming conventions enforced by <enum>.  The 
> prefixes also help relate the enumerations to the requests, fields,  or
> settings to which they apply.  I haven't heard anyone object so  far. 
> (That usually means that nobody noticed or no one cares.)

While in some cases these probably fit well with an <enum>
representation, I suspect some of these might do better as a <const>.
If you find yourself thinking that an <enum> seems rather arbitrarily
constructed just to hold a constant, then we need to implement <const>
and use that instead.

- Josh Triplett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 258 bytes
Desc: OpenPGP digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20060317/10b70c88/signature.pgp


More information about the Xcb mailing list