[Xcb] Branch 'xspec' - xcb-proto

Jeremy A. Kolb jkolb at brandeis.edu
Fri Mar 17 11:11:14 PST 2006


On Fri, 17 Mar 2006, Josh Triplett wrote:

> Ian Osgood wrote:
> > I've also been changing the names of constants as I move them from  X.h
> > to xproto.xml.
> > 
> >  BadRequest   --> XCBRequest (should be XCBBadRequest or  XCBRequestError?)
> >  ShiftMask    --> XCBModMaskShift
> >  Mod1Mask     --> XCBModMask1
> >  Button1Mask  --> XCBButtonMask1
> >  InputOutput  --> XCBWindowClassInputOutput
> >  WhenMapped   --> XCBBackingStoreWhenMapped
> >  KeyPressMask --> XCBEventMaskKeyPress
> >  IsViewable   --> XCBMapStateViewable
> >  CWX          --> XCBConfigWindowX
> >  LineSolid    --> XCBLineStyleSolid
> >  CapButt      --> XCBCapStyleButt
> >  JoinRound    --> XCBJoinStyleRound
> >  FillTile     --> XCBFillStyleTile
> >  WindingRule  --> XCBFillRuleWinding
> >  XYBitmap     --> XCBImageFormatXYBitmap  (should be 
> > XCBImageFormatBitmap?)
> >  LSBFirst     --> XCBImageOrderLSBFirst
> > 
> > This is due mainly to the naming conventions enforced by <enum>.  The 
> > prefixes also help relate the enumerations to the requests, fields,  or
> > settings to which they apply.  I haven't heard anyone object so  far. 
> > (That usually means that nobody noticed or no one cares.)
> 
> While in some cases these probably fit well with an <enum>
> representation, I suspect some of these might do better as a <const>.
> If you find yourself thinking that an <enum> seems rather arbitrarily
> constructed just to hold a constant, then we need to implement <const>
> and use that instead.
> 
> - Josh Triplett
> 

Const would be really sweet for some things.

Jeremy



More information about the Xcb mailing list