[Xcb] Working on RandR 1.2 proto

[Keith Packard]

On Thu, 2006-11-30 at 11:32 -0800, Ian Osgood wrote:

> A few more things:
> 
> • ListOutputProperies has a CARD16 nAtoms field which seems to be  
> ignored by libXrandr, which uses the CARD8 nProperties instead.

The protocol doesn't define nProperties, it appears left in the encoding
header by mistake.

> • libXrandr QueryOutputProperty passes in Atom property, but it is  
> not set into the request.

fixed.

> • sz_xRROUtputChangeNotifyEvent and sz_xRROUtputPropertyNotifyEvent  
> are misspelled (s/U/u/)

Yeah, probably not important; events are always 32 bytes.

> (Is there a historical reason for these sz_* defines instead of using  
> sizeof()?)

alas, on the cray there were no 16 or 32-bit datatypes, so structures
would get padded out to 64-byte boundaries.

Thanks for finding more bugs!

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/xcb/attachments/20061130/ac193806/attachment.pgp