[Xcb] some fixes of the Makefile.am in util/

Jamey Sharp jamey at minilop.net
Wed Feb 21 11:19:26 PST 2007

On Wed, Feb 21, 2007 at 06:50:10PM +0100, Vincent Torri wrote:
> all the names of the libs in util follow that scheme : libXCBMy_lib.*
> I suggest that we rename them as libxcb-my_lib.*, as it is in libxcb right 
> now.

Sounds great: go ahead. Although I guess I'd use hyphen ('-') everywhere
instead of underscore ('_').

> Also, I think that in all the Makefile.am, there's a small mistake:

That's quite likely. :-)

> Instead of adding the content of AM_CFLAGS to foo_CFLAGS, I propose to use 
> foo_CPPFLAGS instead of foo_CFLAGS, which is the correct variable to use, 
> btw.
> Or we can only use AM_CFLAGS et AM_CPPFLAGS, no foo_CPPFLAGS. Which can 
> sometimes simplify the Makefile.am file (see image/Makefile.am, e.g.)

Take whichever approach you like: both sound fine to me.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20070221/00df7b2b/attachment.pgp

More information about the Xcb mailing list