[Xcb] xproto: add any modifier for key?

Barton C Massey bart at cs.pdx.edu
Tue Aug 19 20:25:12 PDT 2008


The protocol specification has both AnyButton and AnyModifier,
so your patch seems like the correct one rather than the
Xlib approach.  It's confused in the protocol by the fact
that the high bit in a mask is supposed to be reserved for
future unspecified "chaining".

I'm not quite sure whether the protocol names should have
been mangled in this way in the first place, though: it
seems like XCB_ANY_MODIFIER and XCB_ANYBUTTON or somesuch
would be better?  Can someone comment on what they think of
all that?

	Bart

In message <20080819085718.GA30392 at abydos.adm.naquadah.org> you wrote:
> The attached patch add the =C2=AB any =C2=BB modifier value for modkey in x=
> proto.
> So you'll get XCB_MOD_MASK_ANY which does not exist right now.
> 
> This is _not_ necessary since you can use XCB_BUTTON_MASK_ANY which is
> the same value (1<<15) but IMHO is confusing when you just want to grab
> keys.
> 
> In xlib it's defined as
> #define AnyModifier (1<<15)
> which, IMHO, is a bit more clear.
> 
> I don't know what the specs are, any light would be appreciated.
> 
> Cheers,


More information about the Xcb mailing list