[Xcb] xproto: add any modifier for key?

Julien Danjou julien at danjou.info
Wed Aug 27 03:18:51 PDT 2008

At 1219202712 time_t, Barton C Massey wrote:
> The protocol specification has both AnyButton and AnyModifier,
> so your patch seems like the correct one rather than the
> Xlib approach.  It's confused in the protocol by the fact
> that the high bit in a mask is supposed to be reserved for
> future unspecified "chaining".

And be careful that AnyButton is not a mask, it's 0L, whereas
AnyModifier is a mask.
AnyModifier in XCB is XCB_BUTTON_MASK_ANY and my patch add XCB_MOD_MASK_ANY
as an identical mask and value.

> I'm not quite sure whether the protocol names should have
> been mangled in this way in the first place, though: it
> seems like XCB_ANY_MODIFIER and XCB_ANYBUTTON or somesuch
> would be better?  Can someone comment on what they think of
> all that?

IMHO, XCB_BUTTON_MASK_ANY should not exist and XCB_MOD_MASK_ANY should.

But having both can't harm.

I'll push that unless someone stop me in the next hours.

Julien Danjou
// ᐰ <julien at danjou.info>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080827/3a92e6f0/attachment.pgp 

More information about the Xcb mailing list