[Xcb] Question about XML spec, and QueryExtension

[Barton C Massey]

Except for the Pbufferclobber event patch, these are all
obviously right.  I suspect that that one is fine too---just
too lazy to check right now.  Thanks much for fixes!

	Bart

In message <20080827095616.GD14183 at abydos.adm.naquadah.org> you wrote:
> 
> --L2Brqb15TUChFOBK
> Content-Type: multipart/mixed; boundary="n+lFg1Zro7sl44OB"
> Content-Disposition: inline
> 
> 
> --n+lFg1Zro7sl44OB
> Content-Type: text/plain; charset=utf-8
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
> 
> At 1219817072 time_t, Barton C Massey wrote:
> > > It would be interesting to compile all of XCB with -Wpadded to see what=
> =20
> > > other bugs there are in the XML definitions. =20
> >=20
> > Indeed.  Someone want to try this?  I suppose I'll get to it eventually
> > if no one else does, but it may be a long while.  I think it just amounts
> > to some kind of compile with and without followed by a diff?
> 
> I did.
> 
> I did not fixed the:
>   warning: padding struct size to alignment boundary
> since I doubt adding padding bytes at the end of the structure
> is useful. If so, I can fix that too.
> 
> I found only 3 relevant warnings, I hope that my fixes are correct.
> 
> This is my first time playing with padding stuff so please,
> Peter and Barton, I'll be happy if you can review this.
> 
> Cheers,
> --=20
Julien Danjou
> // =E1=90=B0 <julien at danjou.info>   http://julien.danjou.info
> // 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
> 
> --n+lFg1Zro7sl44OB
> Content-Type: text/x-diff; charset=utf-8
> Content-Disposition: attachment; filename="0001-xproto-fix-alignment-for-RotateProperties-request.patch"
> Content-Transfer-Encoding: quoted-printable
> 
> =46rom 45d805141c61d3fea3bcfd216c42a7d148a272a7 Mon Sep 17 00:00:00 2001
> =46rom: Julien Danjou <julien at danjou.info>
> Date: Wed, 27 Aug 2008 11:40:52 +0200
> Subject: [PATCH] xproto: fix alignment for RotateProperties request
> 
> Signed-off-by: Julien Danjou <julien at danjou.info>
> ---
>  src/xproto.xml |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/xproto.xml b/src/xproto.xml
> index 0b796a9..343e734 100644
> --- a/src/xproto.xml
> +++ b/src/xproto.xml
> @@ -2189,6 +2189,7 @@ authorization from the authors.
>    </request>
> =20
>    <request name=3D"RotateProperties" opcode=3D"114">
> +    <pad bytes=3D"1" />
>      <field type=3D"WINDOW" name=3D"window" />
>      <field type=3D"CARD16" name=3D"atoms_len" />
>      <field type=3D"INT16" name=3D"delta" />
> --=20
> 1.5.6.3
> 
> 
> --n+lFg1Zro7sl44OB
> Content-Type: text/x-diff; charset=utf-8
> Content-Disposition: attachment; filename="0002-screensaver-add-padding-for-notify-event.patch"
> Content-Transfer-Encoding: quoted-printable
> 
> =46rom 22e4583636b68cbef0dae19a29cc2d6377b83a05 Mon Sep 17 00:00:00 2001
> =46rom: Julien Danjou <julien at danjou.info>
> Date: Wed, 27 Aug 2008 11:50:49 +0200
> Subject: [PATCH] screensaver: add padding for notify event
> 
> Signed-off-by: Julien Danjou <julien at danjou.info>
> ---
>  src/screensaver.xml |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/screensaver.xml b/src/screensaver.xml
> index 8acd292..9c7bccb 100644
> --- a/src/screensaver.xml
> +++ b/src/screensaver.xml
> @@ -115,6 +115,7 @@ Draft Standard Version 1.1
>    <event name=3D"Notify" number=3D"0">
>      <field type=3D"CARD8" name=3D"code"/>
>      <field type=3D"BYTE" name=3D"state"/>    <!-- enum State -->
> +    <pad bytes=3D"1" />
>      <field type=3D"CARD16" name=3D"sequence_number"/>
>      <field type=3D"TIMESTAMP" name=3D"time"/>
>      <field type=3D"WINDOW" name=3D"root"/>
> --=20
> 1.5.6.3
> 
> 
> --n+lFg1Zro7sl44OB
> Content-Type: text/x-diff; charset=utf-8
> Content-Disposition: attachment; filename="0003-glx-add-padding-for-PbufferClobber-event.patch"
> Content-Transfer-Encoding: quoted-printable
> 
> =46rom bdea06d8d4102ae350f81ea8199960ff0afb67aa Mon Sep 17 00:00:00 2001
> =46rom: Julien Danjou <julien at danjou.info>
> Date: Wed, 27 Aug 2008 11:51:06 +0200
> Subject: [PATCH] glx: add padding for PbufferClobber event
> 
> Signed-off-by: Julien Danjou <julien at danjou.info>
> ---
>  src/glx.xml |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/glx.xml b/src/glx.xml
> index 5fedb7b..0f09b28 100644
> --- a/src/glx.xml
> +++ b/src/glx.xml
> @@ -92,6 +92,7 @@ The patch that fixed this server bug in X.org CVS is here:
> =20
>  	<!-- Events -->
>  	<event name=3D"PbufferClobber" number=3D"0">
> +		<pad bytes=3D"1" />
>  		<field type=3D"CARD16" name=3D"event_type" />
>  		<field type=3D"CARD16" name=3D"draw_type" />
>  		<field type=3D"glx:DRAWABLE" name=3D"drawable" />
> --=20
> 1.5.6.3
> 
> 
> --n+lFg1Zro7sl44OB--
> 
> --L2Brqb15TUChFOBK
> Content-Type: application/pgp-signature; name="signature.asc"
> Content-Description: Digital signature
> Content-Disposition: inline
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> 
> iEYEARECAAYFAki1JMAACgkQpGK1HsL+5c2PPwCcD2l/SZb+kEVSE8CDElMtydJD
> 8/gAni8h+9ZhEWJt9Fs4uWm6WQO0bhk8
> =TBHv
> -----END PGP SIGNATURE-----
> 
> --L2Brqb15TUChFOBK--