[Xcb] XCB parsing and valueparam

[Barton C Massey]

I'm a little twitchy about this patch, and indeed this piece
of code.  Should non-fixed-size fields ever appear anywhere
but at the end of a complex type?  If not, why does this
patch change anything?

Thanks much for enlightening me. :-)

	Bart

In message <20080828152325.GF24980 at abydos.adm.naquadah.org> you wrote:
> At 1219936154 time_t, Julien Danjou wrote:
> > Is this a bug or I just miss the whole thing? Hint?
> 
> I found the bug! :-)
> 
> Patch attached.
> 
> --=20
> Julien Danjou
> // =E1=90=B0 <julien at danjou.info>   http://julien.danjou.info
> // 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
> 
> --924gEkU1VlJlwnwX
> Content-Type: text/x-diff; charset=utf-8
> Content-Disposition: attachment; filename="0001-Do-not-break-if-not-fixed_size-continue.patch"
> Content-Transfer-Encoding: quoted-printable
> 
> =46rom 91f6cc61901c25fcf2871b5c083be7dae271b077 Mon Sep 17 00:00:00 2001
> =46rom: Julien Danjou <julien at danjou.info>
> Date: Thu, 28 Aug 2008 17:22:03 +0200
> Subject: [PATCH] Do not break if not fixed_size, continue
> 
> If a type hasn't a fixed size we should not list it but we should
> continue because there can be something after, like padding data.
> 
> Signed-off-by: Julien Danjou <julien at danjou.info>
> ---
>  src/c_client.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/c_client.py b/src/c_client.py
> index 1c6ad16..e9beeda 100755
> --- a/src/c_client.py
> +++ b/src/c_client.py
> @@ -637,7 +637,7 @@ def _c_complex(self):
> =20
>      for field in self.fields:
>          if not field.type.fixed_size():
> -            break
> +            continue
>          if field.wire:
>              struct_fields.append(field)
>         =20
> --=20
> 1.6.0