[Xcb] XCB parsing and valueparam

Julien Danjou julien at danjou.info
Thu Aug 28 23:25:43 PDT 2008


At 1219985104 time_t, Barton C Massey wrote:
> I'm a little twitchy about this patch, and indeed this piece
> of code.  Should non-fixed-size fields ever appear anywhere
> but at the end of a complex type?  If not, why does this
> patch change anything?

Unfortunately, I don't have enough knowledge to answer to your
question Bart.

What I can say is that in:
 833   <request name="ConfigureWindow" opcode="12">
 834     <pad bytes="1" />
 835     <field type="WINDOW" name="window" />
 836     <valueparam value-mask-type="CARD16"
 837                 value-mask-name="value_mask"
 838                 value-list-name="value_list" />
 839     <pad bytes="2" />
 840   </request>

<valueparam/> generates a value_mask uint fixed-size and a value_list
which is a const uint32_t *
The script write the value_mask and stop (break).
So my padding is ignored.
Changing the break to continue has 0 side effect on the code generated
except that it allows my padding to be written. :-)

Cheers,
-- 
Julien Danjou
// ᐰ <julien at danjou.info>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20080829/a69bbaa1/attachment.pgp 


More information about the Xcb mailing list