[Xcb] [xcb-util/icccm]: last call for comments before commit...

[Barton C Massey]

Great work!  Thanks much for taking it on.

Questions and comments:

    * What's a "discriminated atom"?  I'm not getting it.

    * You probably want to put Jamey Sharp's name on the
      icccm copyright list as well; I think he originally
      wrote all of this?  In general, I only put the
      copyright notice of the original author on files; I'm
      not sure that that's legally right, though.

    * Thanks much for adding the doxygen comments in commit
      ba7f7e1e2149388a8475ffd6bcfda659f5267f83.  I'm not so
      excited about the whitespace part of that patch,
      though....
      
Again, thanks.

	Bart

In message <sa5ej3qo0so.fsf at Orfeo.duckcorp.org> you wrote:
> During the last weeks, I worked  on xcb-util/icccm in order to clean the
> API, make it  asynchronous and also document the code a  bit. I also did
> some (minor) changes in xcb-util/atom and xcb-util/property API.
> 
> Julien Danjou already reviewed the commit and it seems ok now.  I tested
> the code within Awesome and it seems  to work fine.  I would like to get
> any  other feedback  about this  API  before committing  it to  xcb-util
> repository, any brave volunteer [0]? ;)
> 
> Cheers,
> Arnaud Fontaine
> 
> [0] http://git.naquadah.org/?p=~arnau/xcb-util.git;a=summary