[Xcb] [PATCH] Add RandR 1.3 requests

Julien Cristau jcristau at debian.org
Tue Apr 21 07:57:36 PDT 2009


One thing I forgot to mention in the patch was that whenever this goes
in and there's a libxcb release, it'd be nice to bump the version-info
for libxcb-randr since this adds new interface.

On Tue, Apr 21, 2009 at 10:37:06 -0400, Peter Harris wrote:

> Julien Cristau wrote:
> > +	<request name="GetPanning" opcode="28">
> > +		<field type="CRTC" name="crtc" />
> > +		<reply>
> > +			<field type="CARD8" name="status" /> <!-- enum SetConfig -->
> enum is an attribute now. That should probably read
> + <field type="CARD8" name="status" enum="SetConfig" />
> (same with the other instances)

Ah, right, I didn't remember what the status was on this.

> I haven't merged my "enumify everything" branch, since nobody has asked
> for it and I haven't finished enumifying all the extensions yet. If you
> like, I can merge that branch now so the rest of randr is enumified (and
> <enum name="SetConfig"> is actually defined) before this goes in.
> http://cgit.freedesktop.org/~peterh/xcbproto-enum/
> What do you think?
Sounds fine to me (haven't reviewed the branch, but what could possibly
go wrong? ;) ).

BTW, I noticed that subpixel_order in render was missing an enum, does
your branch fix this?  If not I'll try to send a patch.


More information about the Xcb mailing list