[Xcb] Win32 port

[jeetu.golani at gmail.com]

Hi,

>>I've gone ahead and merged your tree, on the basis that Bart promised we
>>would[1].

Wow :)....thanks so much :)...means a lot :)

>>For future reference, there are a few things that could be done better
>>next time:

Thanks for pointing this out to me :) I'll keep this in mind for next time.

I'm quite committed to xcb and would like to extend my help here beyond
the windows port. I intend to look closer at segments that I can contribute
to however if anyone here has ideas how I can take my current work forward
or other segments that I could look into please let me know.

Thanks yet again for including my code in the main trunk :)

Jeetu

eBrain
http://ebrain.in
- Discover and Run all software on devices around you. eBrainPool pools in
all of the software on disparate devices over a mesh network. Use any
software in this pool on any device remotely.With eBrainPool, Software and
Computing are truly shared resources.
* Developer code now released





On Wed, Sep 1, 2010 at 4:10 AM, Peter Harris <pharris at opentext.com> wrote:

> On 2010-08-24 05:25, jeetu.golani at gmail.com wrote:
> > It's been a while but I thought I'd check up on whether anyone has
> > managed to try out the Win32 port and how my codebase on github works on
> > Windows and Non-Windows platforms. If I remember correctly at last
> > contact it was decided that once there was feedback on how the code
> > performed across platforms and didn't break anything on non-windows
> > platforms it would be integrated into the main trunk.
>
> Yes, you remember correctly. Thanks for the reminder.
>
> > Pls let me know if there's anything more that I can do to ease inclusion
> > of this port in the main tree :)
>
> I've gone ahead and merged your tree, on the basis that Bart promised we
> would[1].
>
> I fixed up xcb_in.c to include sys/socket.h on non-windows even when
> USE_POLL is defined, otherwise recv is used without being declared.
>
> For future reference, there are a few things that could be done better
> next time:
>  - The big initial commit should (probably) have been split up into
> digestible chunks to make it easier to review.
>  - The later commits to fixup typos and such should have been "squashed"
> into the commit that they fix (see "git rebase -i").
>  - Commit messages should be word-wrapped at 72-ish characters.
>  - Signed-off-by lines are a good idea. We haven't been picky about
> them, but we're trying to use them more now.
>
> Thanks for working on this.
>
> Peter Harris
>
> [1] http://lists.freedesktop.org/archives/xcb/2010-February/005628.html
> --
>               Open Text Connectivity Solutions Group
> Peter Harris                    http://connectivity.opentext.com/
> Research and Development        Phone: +1 905 762 6001
> pharris at opentext.com            Toll Free: 1 877 359 4866
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20100901/fb61429c/attachment.html>