[Xcb] Win32 port - pls review

[Jeetu Golani]

Hi,

I have updated the Win32 port to the current (few weeks old) tree of xcb. Have 
conducted a few rudimentary tests and it seems to perform all right. 

>On Saturday 27 March 2010, Rémi Denis-Courmont wrote:
> I would expect WSASend() to be faster than an iterative send().

I'm not too certain of this. The current design of xcb means that I would have 
too do an iterative loop converting iovec's to a unified WSABUF structure. I 
have done a cursory check online and have still not come up with a definitive 
benefit to choosing WSASend over multiple sends in our case.

One reference from a forum that discusses the issue can be found at 
http://www.codeguru.com/forum/showthread.php?t=305716 

Of course I could be wrong and in which case I'll change the code. For now, 
am keeping it the same.

I would appreciate if this could be reviewed and hopefully merged in with the 
main tree.

Bye for now
Jeetu 
http://www.ebrain.in 
- An open (GPL) platform to discover and run software off someone in the 
meshed network pool and use it on your own device.

twitter:  @0topcat0 and @ebrainpool



On Saturday 27 March 2010, Rémi Denis-Courmont wrote:
> On Thursday 25 March 2010 19:22:21 Jeetu Golani, you wrote:
> > What I would like to do is push this new branch onto my github repo which
> > would then contain the code for the earlier version and the updated (and
> > history).
> >
> > Unfortunately I'm not very good with git :(....I wonder what is the
> >  preferred practice by xcb devels to do this. Should I establish a new
> >  branch at my github repo? How should I tag this new branch? Should I
> > then merge this new branch to the current tree there?
> >
> > I'd appreciate advice (and git steps :) ) to achieve this updation.
> 
> I would expect WSASend() to be faster than an iterative send().
> 
> The ifdef within USE_POLL seems useless.
> 
> I wonder if XCB should be switched to use socket functions for I/O all the
> time. This would avoid most ifdefs. X11 cannot be run over anything but
> sockets anyway.
> 
> It was already mentioned, but I cannot find the windefs.h file anywhere. I
> also find the name a bit confusing considering that Win32 API defines
> <windef.h> (IIRC).
>