[Xcb] Revised version of c_client.py

Peter Harris pharris at opentext.com
Mon Sep 13 09:41:40 PDT 2010

On 2010-09-08 14:55, Ulrich Eckhardt wrote:
> On Wednesday 21 July 2010 22:29:01 Ulrich Eckhardt wrote:
>> I promised recently that I would be working on the looks of the generated
>> sourcecode, and here are my results.[...]
> I know I sent this during the summer holidays, so I guess everybody was 
> outside getting tanned etc, but I'd still like some feedback on this. Also, I 
> sent a mail ("Patch for better error messages in xcbgen") a few days earlier, 
> which is a small fix that should be trivial to verify.

Right now, I'm working on merging the XKB GSoC work. That will be moot
once I get the merge finished.


I still have to decide what to do about automatically calling
unserialize with the same pointer. At the very least, memcpy needs to be
replaced by memmove, but I suspect it'll still be unsafe. I'll probably
end up returning a void * and letting the caller deal with it.

> Are there any questions left? Would you prefer separate patches instead? 
> Anything else?

Definitely separate patches. If you're willing to wait a couple of days,
patches on top of the GSoC XKB merge would be preferred, as it changes
c_client.py quite a bit.

Thanks for reminding us.

Peter Harris
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866

More information about the Xcb mailing list