[Xcb] Bug#629691: libxcb build fails with "nocheck" in DEB_BUILD_OPTIONS

[Steve McIntyre]

On Wed, Jun 08, 2011 at 05:26:05PM +0200, Cyril Brulebois wrote:
>Hi,
>
>and thanks for the report.

Thanks for the quick response. :-)

>Steve McIntyre <steve.mcintyre at linaro.org> (08/06/2011):
>> I'm currently working on cross-building bits of Debian and libxcb
>> fails to build. This is because of the "nocheck" support in
>> debian/rules - I can see how it's meant to work, but it fails: […]
>
>AFAICT dh_auto_test does the right thing when it comes to supporting
>nocheck, so I think that both override_dh_auto_test and check should go
>away entirely. No time to check right now though.

I'm not sure that will do the right thing for the build dir, though,
which is currently set up by doing:

      $(MAKE) -C $(DEB_BUILDDIR) check

<pause>

A quick check suggests it doesn't DTRT. With the existing rules file I
see:

...
make[3]: Entering directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu'
make[2]: Leaving directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu'
make[1]: Leaving directory `/work/stemci01/linaro/armhf/libxcb'
   debian/rules override_dh_auto_test
make[1]: Entering directory `/work/stemci01/linaro/armhf/libxcb'
/usr/bin/make -C obj-x86_64-linux-gnu check
make[2]: Entering directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu'
Making check in src
make[3]: Entering directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu/src'
/usr/bin/make  check-am
make[4]: Entering directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu/src'
make[4]: Nothing to be done for `check-am'.
...

but without the override I see:

...
make[3]: Entering directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu'
make[2]: Leaving directory `/work/stemci01/linaro/armhf/libxcb/obj-x86_64-linux-gnu'
make[1]: Leaving directory `/work/stemci01/linaro/armhf/libxcb'
   dh_auto_test
 fakeroot debian/rules binary
dh binary
   dh_testroot
...

Unless I'm missing something obvious, looks like the override will be
needed as long as the build directory needs to be specified.

Cheers,
-- 
Steve McIntyre
steve.mcintyre at linaro.org