[Xcb] [PATCH] Link xcb-util* with -no-undefined

[Gaetan Nadon]

On Thu, 2011-03-24 at 04:26 +0100, Julien Cristau wrote:

> > Sounds like a  very good idea. Thanks for the  patch. However, could
> you
> > please  add a  variable  (such as  XCB_UTIL_COMMON_LDFLAGS or
> whatever)
> > within  XCB_UTIL_COMMON macro  in  util-common-m4/xcb_util_common.m4
> and
> > use it in the Makefile.am's because it's common to all libraries.
> Thanks
> > much.
> > 
> Sounds like obfuscation to me, but hey...


My first impression was that it's a bit overkill. It stems from good
intentions,
but the reader of the makefile will have one more level of indirection
to find the information. There is a balance between "duplication"
and ease of use.

I wasn't going to mention it, but now that you did...

One general suggestion I have for the xcb modules is to use the patterns
found in xorg (where it makes sense). If we find a better idiom, then
we apply it everywhere. We get both consistency and continuous
improvement.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20110324/dd8fc156/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20110324/dd8fc156/attachment.pgp>