[Xcb] [PATCH xcb/libxcb] Fatal error message when we close libX11 window application

Arvind Umrao arvind.umrao at oracle.com
Mon Oct 24 10:22:32 PDT 2011


On 10/24/2011 10:16 PM, Alan Coopersmith wrote:
> On 10/24/11 01:01, Arvind Umrao wrote:
>>   #define X_TCP_PORT 6000
>>
>> +/** xcb connection shutdown because of connection errors for eg 
>> socket errors, pipe errors and other stream errors. */
>> +#define CONN_ERROR  1
>> +
>> +/**  xcb connection shutdown because of extension not sppported */
>> +#define CONN_CLOSED_EXT_NOTSUPPORTED 2
>> +
>> +/** malloc(), calloc() and realloc() error upon failure, for eg 
>> ENOMEM */
>> +#define CONN_CLOSED_MEMORY_INSUFFICIENT 3
>> +
>> +/** Connection closed, exceeding request length that server 
>> accepts.  */
>> +#define CONN_CLOSED_REQ_LEN_EXCEED  4
>> +
>
> Should those be XCB_CONN_* to avoid namespace clashes with other 
> connection code?
>
>
Yes Alan I agree with you.  Also I should trim error defined names like  
XCB_CN_ERR,  XCB_CN_CLSD_EXT_N_SUP,   XCB_CN_CLSD_MEM_INSUF and  
XCB_CN_CLSD_REQ_LEN_EXCD

Thanks and Regards
-Arvind


More information about the Xcb mailing list