[Xcb] [PATCH xcb/libxcb] Fatal error message when we close libX11 window application

[Alan Coopersmith]

On 10/24/11 10:22, Arvind Umrao wrote:
> On 10/24/2011 10:16 PM, Alan Coopersmith wrote:
>> On 10/24/11 01:01, Arvind Umrao wrote:
>>> #define X_TCP_PORT 6000
>>>
>>> +/** xcb connection shutdown because of connection errors for eg socket
>>> errors, pipe errors and other stream errors. */
>>> +#define CONN_ERROR 1
>>> +
>>> +/** xcb connection shutdown because of extension not sppported */
>>> +#define CONN_CLOSED_EXT_NOTSUPPORTED 2
>>> +
>>> +/** malloc(), calloc() and realloc() error upon failure, for eg ENOMEM */
>>> +#define CONN_CLOSED_MEMORY_INSUFFICIENT 3
>>> +
>>> +/** Connection closed, exceeding request length that server accepts. */
>>> +#define CONN_CLOSED_REQ_LEN_EXCEED 4
>>> +
>>
>> Should those be XCB_CONN_* to avoid namespace clashes with other connection code?
>>
>>
> Yes Alan I agree with you. Also I should trim error defined names like
> XCB_CN_ERR, XCB_CN_CLSD_EXT_N_SUP, XCB_CN_CLSD_MEM_INSUF and
> XCB_CN_CLSD_REQ_LEN_EXCD

I wouldn't trim them like that so that they're unreadable, and XCB_CONN_ as a
prefix for the errors made sense for matching the function name prefix.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System