[Xcb] Null pointer dereference in xcb_image_get

[Peter Harris]

On 2013-08-22 12:57, Bart Massey wrote:
> Somebody please review these. --Bart

For 0005, GetImage always returns the planes MSB first. The bit swap
should be done unconditionally (or the for loop could count down instead
of up, whichever is easier).

"If XYPixmap is specified, only the bit planes specified in plane-mask
are transmitted, with the planes appearing from most significant to
least significant in bit order."  --
http://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#requests:GetImage

The image bit order only describes which bit appears leftmost on the
screen within a plane, and that is (supposed to be) already handled by
xcb_image_create_native.

The rest of the patches look good by eyeball. I haven't tried to compile
them yet.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866