[Xcb] Null pointer dereference in xcb_image_get

[Bart Massey]

Re: 0003, yeah, I read that sentence in the protocol spec, but wasn't
sure whether to read it as "absolute least significant bit" or "least
significant bit in target machine bit order". Since you sound sure
about this, I'll fix it. As you say, it's probably cleaner to just
count the loop down at that point, so OK. Attached. Thanks!

--Bart

On Thu, Aug 22, 2013 at 11:52 AM, Peter Harris <pharris at opentext.com> wrote:
> On 2013-08-22 12:57, Bart Massey wrote:
>> Somebody please review these. --Bart
>
> For 0005, GetImage always returns the planes MSB first. The bit swap
> should be done unconditionally (or the for loop could count down instead
> of up, whichever is easier).
>
> "If XYPixmap is specified, only the bit planes specified in plane-mask
> are transmitted, with the planes appearing from most significant to
> least significant in bit order."  --
> http://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#requests:GetImage
>
> The image bit order only describes which bit appears leftmost on the
> screen within a plane, and that is (supposed to be) already handled by
> xcb_image_create_native.
>
> The rest of the patches look good by eyeball. I haven't tried to compile
> them yet.
>
> Peter Harris
> --
>                Open Text Connectivity Solutions Group
> Peter Harris                    http://connectivity.opentext.com/
> Research and Development        Phone: +1 905 762 6001
> pharris at opentext.com            Toll Free: 1 877 359 4866
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-fixed-endianness-of-image_get-xy-pixmap-loop-again.patch
Type: application/octet-stream
Size: 921 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20130823/d3c031f2/attachment.obj>