[Xcb] Null pointer dereference in xcb_image_get

Peter Harris pharris at opentext.com
Fri Aug 23 08:27:00 PDT 2013


On 2013-08-23 04:25, Bart Massey wrote:
> Re: 0003, yeah, I read that sentence in the protocol spec, but wasn't
> sure whether to read it as "absolute least significant bit" or "least
> significant bit in target machine bit order". Since you sound sure
> about this, I'll fix it. As you say, it's probably cleaner to just
> count the loop down at that point

That's what the server does:
http://cgit.freedesktop.org/xorg/xserver/tree/dix/dispatch.c#n2157
(plane is initialized at
http://cgit.freedesktop.org/xorg/xserver/tree/dix/dispatch.c#n2068 )

So if I'm incorrect in my interpretation of the spec, at least I'm
incorrect in the same way as the server.

>, so OK. Attached. Thanks!

I'd squash this into 0005, but meh.

For the series:
Reviewed-by: Peter Harris <pharris at opentext.com>

Thanks,
 Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the Xcb mailing list