[Xcb] [Bug 71060] xcb-util-cursor trying to create Pixmap of size 0

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 6 22:58:07 CET 2013


--- Comment #8 from Uli Schlachter <psychon at znc.in> ---
Created attachment 88788
  --> https://bugs.freedesktop.org/attachment.cgi?id=88788&action=edit
Check that malloc() succeeds

The error messages from valgrind don't make much sense to me. That sounds like
a broken stack pointer which shouldn't really be possible. However, the other
error messages sound like the stack was smashed and everything went downhill.
Perhaps compiling with -fstack-protector-all can help narrowing this down...

Anyway, the message about read() made me wonder about short reads, thus my
first patch adds error checking to all calls to read(). This second patch now
also checks the result of malloc() (all calloc() calls are already checked).

Also, I kept a tradition alive: Every time I look at xcb-util-cursor, I find
memory leaks. See the comments in the patches.

@ludovic: Could you test if one of these two patches helps your problem or if I
am just finding random issues?

Also, perhaps you could run the test program under strace -e trace=file so that
we can finally figure out which file contains the broken cursor images.

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20131106/e02ea41b/attachment.html>

More information about the Xcb mailing list