[Xcb] [Bug 68387] xinput2 XIQueryDevice reply not read correctly

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Nov 18 07:29:49 PST 2013


Ran Benita <ran234 at gmail.com> changed:

           What    |Removed                     |Added
  Attachment #84415|0                           |1
        is obsolete|                            |

--- Comment #7 from Ran Benita <ran234 at gmail.com> ---
Created attachment 89413
  --> https://bugs.freedesktop.org/attachment.cgi?id=89413&action=edit
reset xcb_block_len (with commit message)

Attached Daniel's patch with a commit message (adapted from the bug).

The diff on the generated code shows some 364 locations where the two lines are
added, all of them _sizeof() functions. Most _sizeof() are not used neither
internally for iterators nor externally (I've never seen them used anywhere),
so could have been broken silently for years. Out of the ones used for
iterators, I believe there are two situations:

- The changes have no semantic change, as in the screens example (see above
comment); it just splits a big "block" to two, having the same end result.

- It fixes a real bug rendering the iterators usable, like in xinput2 and xkb
(the previously attached test crashes without, works with).

The diff is too large for me to inspect every change manually, but I did look
at some random sample. I also tried the patched libxcb with some qt5
applications, and there weren't any problems. So I think the patch should go

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20131118/e58b6316/attachment-0001.html>

More information about the Xcb mailing list