[Xcb] [PATCH] xkb: Fix use of nKTLevels

[Peter Harris]

On 2014-04-29 11:39, Ran Benita wrote:
> Hi Peter
> 
> On Mon, Apr 28, 2014 at 05:05:10PM -0400, Peter Harris wrote:
>> nLevelsPerType is nLevels long, and ktLevelNames is nKTLevels long.
> 
> Can you split the nKTLevels -> nTypes changes to a different commit?
> They obviously seem correct to me, so for those:
> Reviewed-by: Ran Benita <ran234 at gmail.com>
> Tested-by: Ran Benita <ran234 at gmail.com>
> 
> As for the other changes, why do we want to get rid of sumof?

It's one more thing that every single generator has to implement. I'd
like to keep the number of things to a minimum if at all possible.

> Spec says
>     l     LISTofCARD8 nLevelsPerType, sum of all elements=L"
> so it seems appropriate to use it.

The spec is wrong. See the comment added to xkb.xml in
76ca2c0b1527541be59c344118c538ba055ad9d8.

> Also, unfortunately, they cause this diff:
> 
> diff --git a/src/xkb.h b/src/xkb.h
> index 845d1c9..3820bb1 100644
> --- a/src/xkb.h
> +++ b/src/xkb.h
> @@ -9371,6 +9371,7 @@ xcb_xkb_get_names_value_list_radio_group_names_end (const xcb_xkb_get_names_repl
>  int
>  xcb_xkb_get_names_value_list_serialize (void                                 **_buffer  /**< */,
>                                          uint8_t                                nTypes  /**< */,
> +                                        uint16_t                               nKTLevels  /**< */,

Sigh.

Okay, I'd rather not change the libxcb API. I'll respin the patch
without touching <sumof>.

Thanks for the review.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866