[Xcb] [PATCH proto 1/5] xinput: req XIPassiveGrabDevice.time: field is missing in spec

Christian Linhart chris at demorecorder.com
Mon Aug 18 07:41:19 PDT 2014

The request-field "time" is missing in the spec
but it is contained in the code of XI2proto.h.
So, probably the spec has an error.

Add a comment about this, so that future reviewers
won't accidentally remove that field.


 src/xinput.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/xinput.xml b/src/xinput.xml
index 2c8c2b6..72f61fd 100644
--- a/src/xinput.xml
+++ b/src/xinput.xml
@@ -1630,14 +1630,15 @@ <enum name="ModifierMask">
     <struct name="GrabModifierInfo">
         <field type="CARD32" name="modifiers" altenum="ModifierMask" />
         <field type="CARD8"  name="status" enum="GrabStatus" />
         <pad bytes="3" />
     <request name="XIPassiveGrabDevice" opcode="54">
+        <!-- field "time" is missing in the spec, but contained in XI2proto.h -->
         <field type="TIMESTAMP" name="time" altenum="Time" />
         <field type="WINDOW"    name="grab_window" />
         <field type="CURSOR"    name="cursor" />
         <field type="CARD32"    name="detail" />
         <field type="DeviceId"  name="deviceid" altenum="Device" />
         <field type="CARD16"    name="num_modifiers" />
         <field type="CARD16"    name="mask_len" />

More information about the Xcb mailing list