[Xcb] xinput.xml: patches for padding at the end of requests, replies and structs

Ran Benita ran234 at gmail.com
Tue Aug 19 16:54:53 PDT 2014

On Fri, Aug 15, 2014 at 08:26:51PM +0200, Christian Linhart wrote:
> Hi again,
> In the next twelve posts I'll send the xinput-proto patches 
> for the following category:
> "padding at the end of requests, replies and structs" 

These (12) patches all look good to me. I hope the compiler is smart
enough to optimize away all of the always-zero double padding that the
generator inserts here. I bet it does.

Reviewed-by: Ran Benita <ran234 at gmail.com>

> These pads will be useful when we use assertions to compare 
> request/reply-length with interpretation of the data using xcb-protocol defs.
> BTW, Ran, thank you for your suggestions for 
> making the patches easier to review.
> I have applied your suggestions.
> I have also increased the diff-context to 7 lines.
> I hope this helps as well.

That was helpful, thanks.

Btw, for the future, you can do away with the "file-positions may become
wrong" by linking to a specific tag or commit, e.g.


> Chris
> P.S.: I will post the patches for the remaining categories later.
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb

More information about the Xcb mailing list