[Xcb] [PATCH proto 3/3] xinput: req ChangeDeviceProperty: bitcase to case

Christian Linhart chris at DemoRecorder.com
Wed Aug 20 08:57:53 PDT 2014

On 08/20/14 17:46, Peter Harris wrote:
> On 2014-08-19 14:00, Peter Harris wrote:
>> On 2014-08-19 09:55, Christian Linhart wrote:
>>> Change the bitcases to cases
>>> and remove the comment which says that bitcases should converted to cases.
>> This is awesome. Thanks for the series.
>> This patch in particular is
>> Reviewed-by: Peter Harris <pharris at opentext.com>
> Upon closer inspection, this patch only fixes ChangeDeviceProperty.
> There are three more instances of inappropriate bitcase that should also
> be fixed (GetDeviceProperty, XIChangeDeviceProperty, and
> XIGetDeviceProperty).

Yes, I am aware of that. And thank you for noticing.

Reason why I didn't yet change the others:
For now I concentrate on all the parser/generator features 
which need to be implemented for full xinput-support.
For each such feature I only make one xml-example for now.

When that will be finished then I'll do the other needed xml-changes 
( if nobody else made them in the meantime. )

BTW, tomorrow I'll post the following changes to generator:
* support fixed size lists in var-sized structs or in cases.
* support lists of structs which contain a switch
This will enable full support for the QueryDeviceState reply. ( and probably others )
I have done the coding of that today, and the generated code looks OK.
But I still need to test it.


More information about the Xcb mailing list