[Xcb] [PATCH proto 3/3] xinput: req ChangeDeviceProperty: bitcase to case

[Ran Benita]

On Tue, Aug 19, 2014 at 03:55:34PM +0200, Christian Linhart wrote:
> Change the bitcases to cases
> and remove the comment which says that bitcases should converted to cases.

Reviewed-by: Ran Benita <ran234 at gmail.com>

> ---
>  src/xinput.xml | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/src/xinput.xml b/src/xinput.xml
> index 07f6b58..95f0044 100644
> --- a/src/xinput.xml
> +++ b/src/xinput.xml
> @@ -1131,38 +1131,34 @@ <request name="ChangeDeviceProperty" opcode="37">
>          <field type="CARD8" name="device_id" />
>          <field type="CARD8" name="format" enum="PropertyFormat" />
>          <field type="CARD8" name="mode" enum="PropMode" />
>          <pad bytes="1" />
>          <field type="CARD32" name="num_items" />
>          <switch name="items">
>              <fieldref>format</fieldref>
> -            <!-- <bitcase> is not correct, this would need <cases>s.
> -                 It works in that case, because PropertyFormat items can be
> -                 distinguished exactly as their values don't have equal bits.
> -            -->
> -            <bitcase>
> +            <case>
>                  <enumref ref="PropertyFormat">8Bits</enumref>
>                  <list type="CARD8" name="data8">
>                      <fieldref>num_items</fieldref>
>                  </list>
>                  <pad align="4" />
> -            </bitcase>
> -            <bitcase>
> +            </case>
> +            <case>
>                  <enumref ref="PropertyFormat">16Bits</enumref>
>                  <list type="CARD16" name="data16">
>                      <fieldref>num_items</fieldref>
>                  </list>
>                  <pad align="4" />
> -            </bitcase>
> -            <bitcase>
> +            </case>
> +            <case>
>                  <enumref ref="PropertyFormat">32Bits</enumref>
>                  <list type="CARD32" name="data32">
>                      <fieldref>num_items</fieldref>
>                  </list>
> -            </bitcase>
> +            </case>
>          </switch>
>      </request>
>  
>      <!-- DeleteDeviceProperty -->
>  
>      <request name="DeleteDeviceProperty" opcode="38">
>          <field type="ATOM"  name="property" />
> -- 
> 2.0.1
> 
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb