[Xcb] [PATCH proto xkb] Fixes for xkb.xml

Ran Benita ran234 at gmail.com
Fri Feb 21 12:30:09 PST 2014


> From 40e43cad1fdfe073d64ec311c05b1a7c835e9e20 Mon Sep 17 00:00:00 2001
> From: Christian Linhart <chris at DemoRecorder.com>
> Date: Fri, 14 Feb 2014 16:43:22 +0100
> Subject: [PATCH 3/5] xkb: reactivated struct Property
> 
> Reactivated struct Property in the form which was committed
> by Ran Benita on 2013-10-13 as commented out code.
> ---
>  src/xkb.xml |   16 ----------------
>  1 files changed, 0 insertions(+), 16 deletions(-)
> 
> diff --git a/src/xkb.xml b/src/xkb.xml
> index 2caffd4..3484c48 100644
> --- a/src/xkb.xml
> +++ b/src/xkb.xml
> @@ -547,26 +547,10 @@ authorization from the authors.
>  
>  	<typedef oldname="char" newname="STRING8" />
>  
> -	<!-- XXX: Property is broken
> -	<struct name="Property">
> -		<field name="nameLength" type="CARD16" />
> -		<list name="name" type="STRING8">
> -			<fieldref>nameLength</fieldref>
> -		</list>
> -		<field name="valueLength" type="CARD16" />
> -		<list name="value" type="STRING8">
> -			<fieldref>valueLength</fieldref>
> -		</list>
> -	</struct>
> -	-->
> -	<!-- XXX: This would be the correct Property structure as per spec.,
> -		  but it's broken atm. too. Add it anyway here, so we don't
> -		  loose that information.

OK, I think this is really the correct definition to use.
(but please leave the "is broken with libxcb" comment, again so it's
easier to find what needs to be fixed in the generator.)

Ran

>  	<struct name="Property">
>  		<field name="name" type="CountedString16" />
>  		<field name="value" type="CountedString16" />
>  	</struct>
> -	-->
>  
>  	<struct name="Outline">
>  		<field name="nPoints" type="CARD8" />
> -- 
> 1.7.2.5
> 


More information about the Xcb mailing list